Conversation
Collaborator
umswmayj
commented
May 11, 2026
umswmayj
commented
- feat(quota): track instance count (VM count) per project/AZ (feat(quota): track instance count (VM count) per project/AZ #837)
- fix: LIQUID API info and capacity endpoint bugs (fix LIQUID API info and capacity endpoint bugs #838)
Add _instances resource tracking to the quota controller alongside the existing _ram and _cores resources. Each VM counts as 1 instance per project/AZ/flavorGroup. Changes: - computeTotalUsage: accumulate hw_version_<group>_instances (+1 per VM) - accumulateAddedVM: add instances delta (+1) for new VMs - accumulateRemovedVM: add instances decrement (-1) for deleted VMs - Add EnableHVDiff config flag (default: true) to disable incremental HV diff calculation when needed (e.g. for debugging or QA) - Update unit tests and integration tests with instances expectations Since there are no CommittedResources for instances, PaygUsage for instances naturally equals TotalUsage (no CR deduction needed). To disable the HV diff watcher, set enableHVDiff: false in the quota controller config. Only periodic full reconciles will update TotalUsage.
umswmayj
requested review from
PhilippMatthes,
SoWieMarkus,
auhlig,
juliusclausnitzer and
mblos
as code owners
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
SoWieMarkus
approved these changes
May 11, 2026
mblos
approved these changes
May 11, 2026
Contributor
Test Coverage ReportTest Coverage 📊: 69.1% |
mblos
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.